From abc448eca0c754ea7cee0d2f9bfcaa4bbe1245b4 Mon Sep 17 00:00:00 2001 From: "betty \"reenii\" bessa" <56133320+niiree@users.noreply.github.com> Date: Mon, 6 Jun 2022 19:07:59 +0000 Subject: readme: Simplify submodule install process. (#81) * readme: Simplify submodule install process. Not only the linux version did not include any instructions on getting submodules (thus, attempting to follow the guide line-by-line would cause in a unavoiable cmake configure halt before even building), But the usage of `submodule init/update` in it's own can be simplified by using the `--recursive` flag directly in the clone instead. * Only target "submodules" folder for cloning --- README.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 01534de..86df18d 100644 --- a/README.md +++ b/README.md @@ -59,18 +59,17 @@ the result of fundamental issues with Discord's thread implementation. #### Mac: -1. `git clone https://github.com/uowuo/abaddon && cd abaddon` +1. `git clone https://github.com/uowuo/abaddon --recurse-submodules="subprojects" && cd abaddon` 2. `brew install gtkmm3 nlohmann-json` -3. `git submodule update --init subprojects` -4. `mkdir build && cd build` -5. `cmake ..` -6. `make` +3. `mkdir build && cd build` +4. `cmake ..` +5. `make` #### Linux: 1. Install dependencies: `libgtkmm-3.0-dev`, `libcurl4-gnutls-dev`, and [nlohmann-json](https://github.com/nlohmann/json) -2. `git clone https://github.com/uowuo/abaddon && cd abaddon` +2. `git clone https://github.com/uowuo/abaddon --recurse-submodules="subprojects" && cd abaddon` 3. `mkdir build && cd build` 4. `cmake ..` 5. `make` -- cgit v1.2.3 From 2474ffc2ba8dcdc33ac50b12d7697de99efaf358 Mon Sep 17 00:00:00 2001 From: ouwou <26526779+ouwou@users.noreply.github.com> Date: Tue, 14 Jun 2022 02:15:08 -0400 Subject: hoisted_role can be missing from guild member list update --- src/discord/objects.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/discord/objects.cpp b/src/discord/objects.cpp index 6deaca0..f796000 100644 --- a/src/discord/objects.cpp +++ b/src/discord/objects.cpp @@ -41,7 +41,7 @@ void from_json(const nlohmann::json &j, GuildMemberListUpdateMessage::MemberItem JS_D("mute", m.IsMuted); JS_D("joined_at", m.JoinedAt); JS_D("deaf", m.IsDefeaned); - JS_N("hoisted_role", m.HoistedRole); + JS_ON("hoisted_role", m.HoistedRole); JS_ON("premium_since", m.PremiumSince); JS_ON("nick", m.Nickname); JS_ON("presence", m.Presence); -- cgit v1.2.3