diff options
author | ouwou <26526779+ouwou@users.noreply.github.com> | 2022-04-05 22:01:53 -0400 |
---|---|---|
committer | ouwou <26526779+ouwou@users.noreply.github.com> | 2022-04-05 22:01:53 -0400 |
commit | 49685c39895af67d7ffcc50fdc02150b6ee44f72 (patch) | |
tree | 5c5c262f95a30e58582a285b467d05954ff5f35c /src/components/memberlist.cpp | |
parent | 9767e1e7fdef9262211ec676b4f0d4c30ff10649 (diff) | |
download | abaddon-portaudio-49685c39895af67d7ffcc50fdc02150b6ee44f72.tar.gz abaddon-portaudio-49685c39895af67d7ffcc50fdc02150b6ee44f72.zip |
fix up a bunch of clang-tidy stuff
mostly changing references, which i hope doesnt break stuff with models (TreeRow, iterators) since they gave me some strange problems in the past
Diffstat (limited to 'src/components/memberlist.cpp')
-rw-r--r-- | src/components/memberlist.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/components/memberlist.cpp b/src/components/memberlist.cpp index 4f21700..4c95b63 100644 --- a/src/components/memberlist.cpp +++ b/src/components/memberlist.cpp @@ -151,7 +151,7 @@ void MemberList::UpdateMemberList() { if (!pos_role.has_value()) { roleless_users.push_back(id); continue; - }; + } pos_to_role[pos_role->Position] = *pos_role; pos_to_users[pos_role->Position].push_back(std::move(*user)); @@ -161,7 +161,7 @@ void MemberList::UpdateMemberList() { int num_rows = 0; const auto guild = *discord.GetGuild(m_guild_id); - auto add_user = [this, &user_to_color, &num_rows, guild](const UserData &data) -> bool { + auto add_user = [this, &num_rows, guild](const UserData &data) -> bool { if (num_rows++ > MaxMemberListRows) return false; auto *row = Gtk::manage(new MemberListUserRow(guild, data)); m_id_to_row[data.ID] = row; @@ -170,7 +170,7 @@ void MemberList::UpdateMemberList() { return true; }; - auto add_role = [this](std::string name) { + auto add_role = [this](const std::string &name) { auto *role_row = Gtk::manage(new Gtk::ListBoxRow); auto *role_lbl = Gtk::manage(new Gtk::Label); @@ -215,7 +215,7 @@ void MemberList::UpdateMemberList() { } void MemberList::AttachUserMenuHandler(Gtk::ListBoxRow *row, Snowflake id) { - row->signal_button_press_event().connect([this, row, id](GdkEventButton *e) -> bool { + row->signal_button_press_event().connect([this, id](GdkEventButton *e) -> bool { if (e->type == GDK_BUTTON_PRESS && e->button == GDK_BUTTON_SECONDARY) { Abaddon::Get().ShowUserMenu(reinterpret_cast<const GdkEvent *>(e), id, m_guild_id); return true; |